The reverts will continue until morale improves

37 points by kngl 10 hours ago on lobsters | 4 comments

Two9A | 5 hours ago

(After a long paragraph describing pgsql's new "LLM-assisted code review" process:)
A corollary of that is that, at least for the most part, as far as I can tell, this situation is not due to “vibe coding”.

You'll excuse me if I'm not entirely convinced.

refi64 | 4 hours ago

I mean

But there was also a long tail of relatively harmless issues involving various edge cases. In past times, many of these would not have surfaced until much later and we would have fixed them bit by bit over the subsequent five years. But with LLM-assisted code review, these kinds of things can get found much faster, and then you’re staring at a list of like forty defect reports. And even if each of them requires only a three-line fix on average, there is a fixed overhead to dealing with each of these, and then you run out of time. Most if not all of the affected reverted features were written a long time ago when LLM-assisted code review was not as useful as it is now, meaning that the effective quality bar has been raised after the time the feature was written and committed.

and then

A corollary of that is that, at least for the most part, as far as I can tell, this situation is not due to “vibe coding”. This code was written well before that was a possibility.

I think this is a fair explanation? That is:

  • The code is human-written, if not just because at the time the relevant code was written LLMs were even worse at writing code, so it does truly not fall under the usual definition of "vibe coding".
  • LLMs are relatively good at finding bugs, as has been widely documented, e.g. from the curl maintainer. Of course, there are entities that would like to exaggerate this for marketing, but fundamentally there are many bugs that aren't that novel but still escape human eyes due to being deep within large amounts of code. So it's not unsurprising that an LLM could find issues in what I expect to be some pretty complex database innards.

dualvariable | 4 hours ago

Yeah, I still often write code manually to stay in touch with the codebase and struggle with it in my head. After throwing an LLM at my code, it usually finds a ton of derp and second-order bugs that I have to admit it is right (although sometimes it is still very wrong).

SamRW | 2 hours ago

We've had vibe code for like three years now. Surely at least it was a possibility...